Re: [PATCH] abspath.h file is generated by makeheaders tool

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Oct 12, 2022, 09:04 UTC
Message-ID: <221012.86r0zdmmq1.gmgdl@evledraar.gmail.com>
In-Reply-To: <pull.1353.git.git.1665563819680.gitgitgadget@gmail.com>

On Wed, Oct 12 2022, skrab-sah via GitGitGadget wrote:

Show 7 quoted lines

> From: skrab-sah <skrab.sah@gmail.com>
>
> 1. We don't need to commit the file.
> 2. Added routin for abspath.c in Makefile.
> 3. Added tool support for makeheaders.
>
> Signed-off-by: skrab-sah <skrab.sah@gmail.com>

Not to repeat earlier feedback, but I really think you need to read & internalize some of it rather than keep submitting these: https://lore.kernel.org/git/?q=skrab-sah

Not commenting on much of this, except:

Show 8 quoted lines

> @@ -1,5 +1,21 @@
>  # The default target of this Makefile is...
> -all::
> +all:: hdr
> +
> +
> +# In parallel mode things goes up and down.
> +.NOTPARALLEL:

I think this really goes to what i was pointing out in https://lore.kernel.org/git/220923.861qs25yr8.gmgdl@evledraar.gmail.com/

You're making very fundimental changes to a subsystem that your changes themselves show you clearly don't understand that well.

Firstly, we have a lot of things in this makefile which don't require C compilation, so putting a "hdr" as an "all" dependency is a no-go.

Secondly, you've globally marked our Makefile as "nothing here can run in parallel", i.e. the single biggest slowdown it's ever had, presumably because you got some dependency chain wrong, and are usin git as a workaround.