git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] setup: clarify TODO comment about ignoring core.bare

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 29, 2024, 19:15 UTC
Message-ID
<xmqqsf1bf5ew.fsf@gitster.g>
In-Reply-To
<20240229134114.285393-2-shyamthakkar001@gmail.com>
Ghanshyam Thakkar <shyamthakkar001@gmail.com> writes:
Show 13 quoted lines
>  	/*
> -	 * TODO: heed core.bare from config file in templates if no
> -	 *       command-line override given
> +	 * Note: The below line simply checks the presence of worktree (the
> +	 * simplification of which is given after the line) and core.bare from
> +	 * config file is not taken into account when deciding if the worktree
> +	 * should be created or not, even if no command line override given.
> +	 * That is intentional. Therefore, if in future we want to heed
> +	 * core.bare from config file, we should do it before we create any
> +	 * subsequent directories for worktree or repo because until this point
> +	 * they should already be created.
>  	 */
>  	is_bare_repository_cfg = prev_bare_repository || !work_tree;

I do not recall the discussion; others may want to discuss if the change above is desirable, before I come back to the topic later.

But I see this long comment totally unnecessary and distracting.
Show 11 quoted lines
> -	/* TODO (continued):
> +	/* Note (continued):
>  	 *
> -	 * Unfortunately, the line above is equivalent to
> +	 * The line above is equivalent to
>  	 *    is_bare_repository_cfg = !work_tree;
> -	 * which ignores the config entirely even if no `--[no-]bare`
> -	 * command line option was present.
>  	 *
>  	 * To see why, note that before this function, there was this call:
>  	 *    prev_bare_repository = is_bare_repository()

If it can be proven that the assignment can be simplified to lose the "prev_bare_repository ||" part, then the above comment can be used as part of the proposed log message for a commit that makes such a change. There is no reason to leave such a long comment to leave the more complex "A || B" expression when it can be simplified to "B", no?

Thanks.
Previous: Ghanshyam ThakkarNext: Ghanshyam Thakkar
Message 10 of 15 in “[GSOC][RFC] Heed core.bare from template config file when no command line override given, as a microproject.”
  1. Ghanshyam ThakkarJan 2, 2024
  2. Christian CouderJan 4, 2024
  3. Ghanshyam ThakkarJan 4, 2024
  4. Elijah NewrenJan 5, 2024
  5. Junio C HamanoJan 5, 2024
  6. Ghanshyam ThakkarJan 6, 2024
  7. Junio C HamanoJan 8, 2024
  8. Elijah NewrenJan 19, 2024
  9. setup: clarify TODO comment about ignoring core.bareGhanshyam Thakkar, Feb 29, 2024
  10. Junio C HamanoFeb 29, 2024
  11. Ghanshyam ThakkarFeb 29, 2024
  12. setup: remove unnecessary variableGhanshyam Thakkar, Mar 4, 2024
  13. Junio C HamanoMar 4, 2024
  14. Ghanshyam ThakkarMar 4, 2024
  15. Junio C HamanoMar 4, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.