git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] setup: remove unnecessary variable

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 4, 2024, 21:53 UTC
Message-ID
<xmqq8r2xoe8g.fsf@gitster.g>
In-Reply-To
<CZLA8TF4XG5S.KU06P62V03TV@gmail.com>
"Ghanshyam Thakkar" <shyamthakkar001@gmail.com> writes:
Show 5 quoted lines
> Yes, in the previous testcase we determined that template cannot set
> core.bare. Therefore, this testcase would be like testing
> --bare/--no-bare option, which is already done in 0001-init.sh and
> t5601-clone.sh. However, I don't have strong opinion on this. I can add
> it back if you think it is worth it.

I was merely trying to make sure that I understood your motivation behind the change, which was described at the end of the commit log message, i.e. "... and remove one redundant testcase.".

Thanks.
Previous: Ghanshyam Thakkar
Message 15 of 15 in “[GSOC][RFC] Heed core.bare from template config file when no command line override given, as a microproject.”
  1. Ghanshyam ThakkarJan 2, 2024
  2. Christian CouderJan 4, 2024
  3. Ghanshyam ThakkarJan 4, 2024
  4. Elijah NewrenJan 5, 2024
  5. Junio C HamanoJan 5, 2024
  6. Ghanshyam ThakkarJan 6, 2024
  7. Junio C HamanoJan 8, 2024
  8. Elijah NewrenJan 19, 2024
  9. setup: clarify TODO comment about ignoring core.bareGhanshyam Thakkar, Feb 29, 2024
  10. Junio C HamanoFeb 29, 2024
  11. Ghanshyam ThakkarFeb 29, 2024
  12. setup: remove unnecessary variableGhanshyam Thakkar, Mar 4, 2024
  13. Junio C HamanoMar 4, 2024
  14. Ghanshyam ThakkarMar 4, 2024
  15. Junio C HamanoMar 4, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.