Re: [PATCH v2] setup: remove unnecessary variable

From: Ghanshyam Thakkar <shyamthakkar001@gmail.com>
Date: Mar 4, 2024, 21:27 UTC
Message-ID: <CZLA8TF4XG5S.KU06P62V03TV@gmail.com>
In-Reply-To: <xmqqjzmhq2vb.fsf@gitster.g>

On Mon Mar 4, 2024 at 11:46 PM IST, Junio C Hamano wrote:

Show 16 quoted lines

> Ghanshyam Thakkar <shyamthakkar001@gmail.com> writes:
> > -
> > -test_expect_success 'template can set core.bare but overridden by command line' '
> > -	test_when_finished "rm -rf subdir" &&
> > -	test_when_finished "rm -rf templates" &&
> > -	test_config core.bare true &&
> > -	umask 0022 &&
> > -	mkdir -p templates/ &&
> > -	cp .git/config templates/config &&
> > -	git init --no-bare --template=templates subdir &&
> > -	test_path_exists subdir/.git/HEAD
> > -'
>
> This removal is a bit unexpected.  Is it because we established with
> the previous test that core.bare in the template should not affect
> the outcome, so this is not worth testing?

Yes, in the previous testcase we determined that template cannot set core.bare. Therefore, this testcase would be like testing --bare/--no-bare option, which is already done in 0001-init.sh and t5601-clone.sh. However, I don't have strong opinion on this. I can add it back if you think it is worth it.

Thanks.