Re: [PATCH] fetch: fix following tags when fetching specific OID

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 8, 2025, 00:10 UTC
Message-ID: <xmqqsenobcx1.fsf@gitster.g>
In-Reply-To: <61147be4b9a0ee76f1fe0f3376d7316205da350c.1741389941.git.me@ttaylorr.com>

Taylor Blau <me@ttaylorr.com> writes:

> Fix this by only adding "HEAD" to the ref prefixes when we know that we
> are already limiting the advertisement. In either case we'll learn about
> HEAD (either through the limited advertisement, or implicitly through a
> full advertisement).

Good. "implicitly through a full advertisement" is a good thing to explicitly state here ;-)

Show 14 quoted lines

> Reported-by: Igor Todorovski <itodorov@ca.ibm.com>
> Co-authored-by: Jeff King <peff@peff.net>
> Signed-off-by: Jeff King <peff@peff.net>
> Signed-off-by: Taylor Blau <me@ttaylorr.com>
> ---
> Peff and I talked about this today, and neither of us could find any
> reasons not to pursue the approach listed in the footnote of
>
>   <20250221072558.GA572877@coredump.intra.peff.net>
>
> , but this is a more conservative approach that should fix the issue and
> apply cleanly on top of 'maint'. It may be worth picking this into 2.49,
> even though we are already quite late into the -rc cycle, this is a
> fairly nasty bug.

Thanks, both.