Re: [PATCH 1/4] refspec: treat 'fetch' as a Boolean value

From: Jeff King <peff@peff.net>
Date: Mar 18, 2025, 00:26 UTC
Message-ID: <20250318002616.GA1470685@coredump.intra.peff.net>
In-Reply-To: <20250318002436.GC1470172@coredump.intra.peff.net>

On Mon, Mar 17, 2025 at 08:24:36PM -0400, Jeff King wrote:

Show 5 quoted lines

> > -	refspec_item_init_or_die(&spec, refspec, REFSPEC_FETCH);
> > +	refspec_item_init_or_die(&spec, refspec, 1);
> 
> The third argument here (and elsewhere) becomes much more mysterious to
> the reader.  Maybe not a big deal, though.

Oh, I should have read the other patches. :)

The end result resolves my complaint nicely.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.