Re: [PATCH 0/9] fetch: further ref-prefix cleanups and optimizations

From: Taylor Blau <me@ttaylorr.com>
Date: Mar 12, 2025, 21:49 UTC
Message-ID: <Z9IBZmh4Cr2jq7E4@nand.local>
In-Reply-To: <Z9H8uKevHUxasE4S@nand.local>

On Wed, Mar 12, 2025 at 05:29:28PM -0400, Taylor Blau wrote:

Show 7 quoted lines

> >  builtin/fetch.c        | 46 +++++++++++++++++-------------------------
> >  refspec.c              | 22 ++++++++++++++------
> >  t/t5516-fetch-push.sh  | 12 ++++++-----
> >  t/t5702-protocol-v2.sh | 44 +++++++++++++++++++++++++++++++++++++++-
> >  4 files changed, 85 insertions(+), 39 deletions(-)
>
> Kidding, of course, I am looking forward to reviewing it now.

This looks great to me. I left a few minor comments throughout, but am unsurprisingly on-board with the overall approach as you and I discussed this off-list a week or two ago.

    Reviewed-by: Taylor Blau <me@ttaylorr.com>

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.