Re: [PATCH 1/6] object-file: rename files transaction prepare function
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 24, 2026, 18:26 UTC
- Message-ID
- <xmqqse6biyma.fsf@gitster.g>
- In-Reply-To
- <20260624041920.2601961-2-jltobler@gmail.com>
Justin Tobler <jltobler@gmail.com> writes:
Show 6 quoted lines
> The "files" ODB transaction backend lazily creates a temporary object > directory when the first loose object is written to the transaction via > `prepare_loose_object_transaction()`. In a subsequent commit, the > temporary directory is used to also write packfiles to. > > Rename the function to `odb_transaction_files_prepare()` accordingly.
Taken by itself this renaming does make sense, but there are many other function that follow the historical naming convention, like {fsync,flush}_loose_object_transaction(). Should we rename them for consistency with the new naming scheme, not necessarily as part of this series but with a todo comment to do so once the dust settles, or something?