Re: [PATCH v2 10/11] builtin/receive-pack: drop redundant tmpdir env
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Jul 8, 2026, 06:41 UTC
- Message-ID
- <ak3xNaHeMli-H1wW@pks.im>
- In-Reply-To
- <20260708041412.1157499-11-jltobler@gmail.com>
On Tue, Jul 07, 2026 at 11:14:11PM -0500, Justin Tobler wrote:
Show 6 quoted lines
> When performing the connectivity checks for a shallow ref in > `update_shallow_ref()`, the child process environment variables are > populated via `tmp_objdir_env()`. This is unnecessary though as > `update_shallow_ref()` is only reached after `tmp_objdir_migrate()` has > been performed which means there is no longer a temporary directory that > needs to be shared with child processes.
Right. We call it transitively via either `execute_commands_atomic()` or `execute_commands_not_atomic()`, both of which are called after `tmp_objdir_migrate()`.
Patrick