Re: [PATCH 4/6] odb/transaction: propagate commit errors
- From
Justin Tobler <jltobler@gmail.com>
- Date
- Jun 29, 2026, 19:16 UTC
- Message-ID
- <akLEigsjg3TaIEcb@denethor>
- In-Reply-To
- <aju-90Uayxwsevm7@pks.im>
On 26/06/24 01:26PM, Patrick Steinhardt wrote:
Show 15 quoted lines
> On Tue, Jun 23, 2026 at 11:19:18PM -0500, Justin Tobler wrote: > > diff --git a/odb/transaction.h b/odb/transaction.h > > index cd6d50f2e5..7898770071 100644 > > --- a/odb/transaction.h > > +++ b/odb/transaction.h > > @@ -54,7 +54,7 @@ static inline void odb_transaction_begin_or_die(struct object_database *odb, > > * Commits an ODB transaction making the written objects visible. If the > > * specified transaction is NULL, the function is a no-op. > > */ > > -void odb_transaction_commit(struct odb_transaction *transaction); > > +int odb_transaction_commit(struct odb_transaction *transaction); > > Should the function comment be amended, as well? We should definitely > point out that calling this with a NULL transaction also returns > success.
Will do in the next version.
Thanks, -Justin