Re: [PATCH][GSOC] Selection of the verbose message is replaced with generated message in install_branch_config()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 21, 2014, 17:09 UTC
- Message-ID
- <xmqqr45vv5q8.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <CAPig+cRv-WvoMVY0PDgtLawywe0QfpX8oPetzNwD-9Jq6BOjyw@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
> Sorry, you're right about message[0] case not being a crasher (though > the assert() still seems overkill).
Assert() often becomes no-op in production build. I think this may be an indication that "table-driven" may not be as good an approach as many candidates thought. The microproject suggestion asks them to think _if_ that makes sense, and it is perfectly fine for them if they answer "no, it introduces more problems than it solves".