git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH][GSOC] Selection of the verbose message is replaced with generated message in install_branch_config()

From
AMAleksey Mokhovikov <moxobukob@gmail.com>
Date
Mar 18, 2014, 14:37 UTC
Message-ID
<lg9l9t$uaa$1@ger.gmane.org>
In-Reply-To
<CAPig+cQ_gvDWKkgN543TZtfGOqDkH0EYS39w+eEw8CdJO9Ux3Q@mail.gmail.com>
Eric Sunshine <sunshine <at> sunshineco.com> writes:
Show 17 quoted lines
> The subject should be concise. Try to keep it at 65-70 characters or
> less. More detailed information can be written following the subject
> (separated from the subject by a blank line).
>
> Write in imperative tone: say "replace X with Y" rather than "X is
> replaced with Y".
>
> Mention the module or function you're touching.
>
> You might say something like this:
>
>     Subject: install_branch_config: replace if-chain with string composition
> Wrap lines to 65-70 characters.
>
> This prose is almost pure email commentary. It doesn't really convey
> useful information to a person reading the patch months or years from
> now. Place commentary below the "---" line under your sign-off.
Thanks a lot for you language and message formatting style advices.

I've make a new patch taking into account the GNU gettext requirements. I don't know if I should create a new thread for another patch, but

I'd be glad if you will give me some information about new patch: http://permalink.gmane.org/gmane.comp.version-control.git/244357

Previous: Eric SunshineNext: Aleksey Mokhovikov
Message 5 of 16 in “[GSOC] Selection of the verbose message is replaced with generated message in install_branch_config()”
  1. [GSOC] Selection of the verbose message is replaced with generated message in install_branch_config()Aleksey Mokhovikov, Mar 17, 2014
  2. Matthieu MoyMar 17, 2014
  3. Aleksey MokhovikovMar 18, 2014
  4. Eric SunshineMar 17, 2014
  5. Aleksey MokhovikovMar 18, 2014
  6. Aleksey MokhovikovMar 18, 2014
  7. Aleksey MokhovikovMar 18, 2014
  8. Eric SunshineMar 19, 2014
  9. Aleksey MokhovikovMar 20, 2014
  10. Eric SunshineMar 21, 2014
  11. Junio C HamanoMar 21, 2014
  12. Michael HaggertyMar 21, 2014
  13. Eric SunshineMar 21, 2014
  14. Michael HaggertyMar 21, 2014
  15. Aleksey MokhovikovMar 24, 2014
  16. Michael HaggertyMar 24, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.