git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH][GSOC] Selection of the verbose message is replaced with generated message in install_branch_config()

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Mar 24, 2014, 12:22 UTC
Message-ID
<53302395.6090207@alum.mit.edu>
In-Reply-To
<lgomc3$rh0$1@ger.gmane.org>
On 03/24/2014 08:28 AM, Aleksey Mokhovikov wrote:
Show 24 quoted lines
> On 03/22/2014 04:13 AM, Michael Haggerty wrote:
>> My expectation when I invented that microproject was that converting the
>> code to be table-driven would be judged *not* to be an improvement.  I
>> was hoping that a student would say "the 'if' statement is OK, but let's
>> delete this ridiculous unreachable else branch".  Possibly they would
>> convert the "if" chain into nested "if"s, which I think would allow some
>> code consolidation in one of the branches.
>>
>> But not a single student agreed with me, so I must be in a minority of
>> one (which, unfortunately, is the definition of lunacy).
>>
>> The multidimensional array lookup table is not so terrible, but I
>> personally still prefer the "if".
> 
> That was expectable. But the main goal for me was to participate in git
> development process, to become familiar with it.
> It looks hard to participate when not proposing a patch.
> I thought about make a small change in if chain, but it looked to minor
> to feel whole development process.
> I've used git features for formatting and sending a patch to mailing list.
> I've met the GNU gettext restrictions when proposed a first patch.
> Proposed another patch and tried to show Pros and Cons.
> It didn't look like applying a patch to git master branch was the main goal.
> As for me that was quite interesting and useful.

Sorry if there was a misunderstanding. I didn't mean to criticize you and certainly not to single you out among the many students who went for a table-driven solution. I was rather replying to Junio's general comment, that maybe changing the code to be table-driven wasn't such a good idea. These things are always a matter a taste, and sometimes hard to predict before one has tried writing the code a couple of different ways.

Michael
-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
Previous: Aleksey Mokhovikov
Message 16 of 16 in “[GSOC] Selection of the verbose message is replaced with generated message in install_branch_config()”
  1. [GSOC] Selection of the verbose message is replaced with generated message in install_branch_config()Aleksey Mokhovikov, Mar 17, 2014
  2. Matthieu MoyMar 17, 2014
  3. Aleksey MokhovikovMar 18, 2014
  4. Eric SunshineMar 17, 2014
  5. Aleksey MokhovikovMar 18, 2014
  6. Aleksey MokhovikovMar 18, 2014
  7. Aleksey MokhovikovMar 18, 2014
  8. Eric SunshineMar 19, 2014
  9. Aleksey MokhovikovMar 20, 2014
  10. Eric SunshineMar 21, 2014
  11. Junio C HamanoMar 21, 2014
  12. Michael HaggertyMar 21, 2014
  13. Eric SunshineMar 21, 2014
  14. Michael HaggertyMar 21, 2014
  15. Aleksey MokhovikovMar 24, 2014
  16. Michael HaggertyMar 24, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.