Re: [PATCH] filter-branch: resolve $commit^{tree} in no-index case
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 19, 2016, 22:23 UTC
- Message-ID
- <xmqqr3hd8azs.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20160119220722.GB6556@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 19 quoted lines
> Actually, I ended up not including the part about doing that comparison. > So the commit message isn't _wrong_, but it is incomplete. This > paragraph: > > However, the value of $tree here is technically > user-visible. The user can provide arbitrary shell code at > this stage, which could itself have a similar assumption to > what is in git_commit_non_empty_tree. So the conservative > choice to fix this regression is to take the 20% hit and > give the pre-348d4f2 behavior. > > should start with something like: > > We could try to make git_commit_non_empty_tree more clever. > > to make it clear why we care about the user-visibility of the variable > in the first place. > > Here is a re-roll with that fixup.
Thanks. I failed to spot and realize that $tree is also part of what we expose and end-user scripts may already be looking at when I commented, and I agree with the reasoning behind this conservative route.
Will queue.