Re: [PATCH] filter-branch: resolve $commit^{tree} in no-index case

From: Jeff King <peff@peff.net>
Date: Jan 19, 2016, 21:59 UTC
Message-ID: <20160119215928.GA6556@sigill.intra.peff.net>
In-Reply-To: <20160119215100.GB28656@sigill.intra.peff.net>

On Tue, Jan 19, 2016 at 04:51:00PM -0500, Jeff King wrote:

> Here's the patch I came up with. It takes the conservative choice (see
> the argument below), and shows the performance impact. I'll work up the
> non-conservative one on top, which I think can do even better than the
> original.

Oh, never mind. I had thought we could do away with _both_ rev-parses and compare "foo^{tree}" to "foo^{tree}".

But of course that does not work. Because it is really "$commit^{tree}" versus "$parent^{tree}" here. I need to update the commit message below.

We could get away "git diff --exit-code $1 $2" to do a single process invocation (rather than two rev-parses), but I don't know if it is worth the complexity.

-Peff