Re: git filter-branch not removing commits when it should in 2.7.0
- From
Jeff King <peff@peff.net>
- Date
- Jan 19, 2016, 21:37 UTC
- Message-ID
- <20160119213705.GA28656@sigill.intra.peff.net>
- In-Reply-To
- <xmqq7fj59rs2.fsf@gitster.mtv.corp.google.com>
On Tue, Jan 19, 2016 at 01:35:25PM -0800, Junio C Hamano wrote:
> In other words, would the fix be a one-liner like this?
> [...]
> - tree="$commit^{tree}"
> + tree=$(git rev-parse "$commit^{tree}")Yes, I was just writing up the commit message for it. :-/
It _is_ slower, though, because it introduces an extra rev-parse. When we could in fact be getting rid of one. Give me a moment to complete a few timing tests and post the results.
-Peff