Re: [PATCH] git-svn: shorten glob error message
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 27, 2016, 20:26 UTC
- Message-ID
- <xmqqr3h27oqr.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20160127025408.GA17600@dcvr.yhbt.net>
Eric Wong <normalperson@yhbt.net> writes:
Show 11 quoted lines
> Junio C Hamano <gitster@pobox.com> wrote:
>> I am not sure if it is a good idea to show */*/* as an example in
>> the message (that is an anti-example of 'one set of wildcard' by
>> having three stars, isn't it?), but that is not a new issue this
>> change introduces.
>
> Actually, going back to commit 570d35c26dfbc40757da6032cdc96afb58cc0037
> ("git-svn: Allow deep branch names by supporting multi-globs"),
> having equal '*' on both sides is all that is required.
>
> Not sure how to improve the wording, though...I dunno, either, and that is why "not a new issue", iow, the patch is good as-is. The wording might be an area with possible future improvement, but that does not have to block the improvement the patch under discussion brings us.
Thanks.