git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-svn: shorten glob error message

From
VLVictor Leschuk <vleschuk@accesssoftek.com>
Date
Jan 22, 2016, 16:07 UTC
Message-ID
<1453478851657.1340@accesssoftek.com>
In-Reply-To
<xmqqvb6wjacq.fsf@gitster.mtv.corp.google.com>
Hello all,
On 01/14/2016 09:15 PM, Junio C Hamano wrote:
Show 27 quoted lines
> Eric Wong <normalperson@yhbt.net> writes:
>
>> Error messages should attempt to fit within the confines of
>> an 80-column terminal to avoid compatibility and accessibility
>> problems.  Furthermore the word "directories" can be misleading
>> when used in the context of git refnames.
>>
>> Signed-off-by: Eric Wong <normalperson@yhbt.net>
>> ---
>>    Eric Wong <normalperson@yhbt.net> wrote:
>>    > I also noticed the "Only one set of wildcard directories" error
>>    > message is unnecessary long and "wildcard directories" should
>>    > probably be shortened to "wildcards" to avoid wrapping in a terminal.
>>    > That will probably be a separate patch for me.
>>
>>    There's likely more instances of this in git-svn, but I figured
>>    we'll get this one fixed, first.
>>
>>    Also pushed to bogomips.org/git-svn.git
>>    (commit dc6aa7e61e9d33856f54d63b7acb518383420373)
>>    along with Victor's patch.
> Thanks.
>
> I am not sure if it is a good idea to show */*/* as an example in
> the message (that is an anti-example of 'one set of wildcard' by
> having three stars, isn't it?), but that is not a new issue this
> change introduces.

I agree, this should be changed, however I think this should be done in separate patch.

Do we have any questions left open before this could be merged into main git repo?

-- Victor

Previous: Junio C HamanoNext: Eric Wong
Message 8 of 10 in “git-svn: loosen config globs limitations”
  1. git-svn: loosen config globs limitationsVictor Leschuk, Jan 11, 2016
  2. Eric WongJan 13, 2016
  3. Victor LeschukJan 13, 2016
  4. Junio C HamanoJan 13, 2016
  5. Eric WongJan 13, 2016
  6. git-svn: shorten glob error messageEric Wong, Jan 14, 2016
  7. Junio C HamanoJan 14, 2016
  8. Victor LeschukJan 22, 2016
  9. Eric WongJan 27, 2016
  10. Junio C HamanoJan 27, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.