Re: [PATCH] git-svn: shorten glob error message

From: Eric Wong <normalperson@yhbt.net>
Date: Jan 27, 2016, 02:54 UTC
Message-ID: <20160127025408.GA17600@dcvr.yhbt.net>
In-Reply-To: <xmqqvb6wjacq.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> wrote:

> I am not sure if it is a good idea to show */*/* as an example in
> the message (that is an anti-example of 'one set of wildcard' by
> having three stars, isn't it?), but that is not a new issue this
> change introduces.

Actually, going back to commit 570d35c26dfbc40757da6032cdc96afb58cc0037 ("git-svn: Allow deep branch names by supporting multi-globs"), having equal '*' on both sides is all that is required.

Not sure how to improve the wording, though...

Show 8 quoted lines

> >  	my $state = "left";
> > -	my $die_msg = "Only one set of wildcard directories " .
> > -				"(e.g. '*' or '*/*/*') is supported: '$glob'\n";
> > +	my $die_msg = "Only one set of wildcards " .
> > +				"(e.g. '*' or '*/*/*') is supported: $glob\n";
> >  	for my $part (split(m|/|, $glob)) {
> >  		if ($pattern_ok && $part =~ /[{}]/ &&
> >  			 $part !~ /^\{[^{}]+\}/) {