Re: git submodule should honor "-c credential.helper" command line argument
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 19, 2016, 17:33 UTC
- Message-ID
- <xmqqr3g8d2pn.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20160219043019.GA14764@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 5 quoted lines
> That being said, I am not sure this is the right solution. In the thread > I linked earlier[1], Jens indicated he would prefer not to blindly share > config with the submodules, and I think I agree. Or are you proposing to > pick and choose the keys in GIT_CONFIG_PARAMETERS, and whitelist > credential.*?
Yes, I think it is sensible not to propagate by default, and pass ones that are absolutely safe, sane and necessary by whitelisting.