git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git submodule should honor "-c credential.helper" command line argument

From
Jacob Keller <jacob.keller@gmail.com>
Date
Feb 7, 2016, 04:41 UTC
Message-ID
<CA+P7+xr4gQFPsUiuqSzMsUJP6_W8FnXBwX1Xes=XjksuTs=+hQ@mail.gmail.com>
In-Reply-To
<CA+P7+xpGTvbyLOKQ=DHFBLOuVNN8WocraaZQhFD36oDiFrY+sA@mail.gmail.com>
On Wed, Feb 3, 2016 at 3:44 PM, Jacob Keller <jacob.keller@gmail.com> wrote:
Show 10 quoted lines
> Ok so I am not sure we even really need to use "-c" option in
> git-clone considering that we can just use the same flow we do for
> setting core.worktree values. I'll propose a patch with you two Cc'ed,
> which I think fixes the issue. There may actually be a set of
> configuration we want to include though, and the main issue I see is
> that it won't get updated correctly whenever the parent configuration
> changes.
>
> Thanks,
> Jake

I tried adding the config as part of module_clone in submodule--helper.c but it didn't pass the test I added. I haven't had time to look at this in the last few days, but I am stuck as to why submodule--helper.c appeared to not use module_clone as I thought.

Regards, Jake

Previous: Jacob KellerNext: Marc Strapetz
Message 6 of 15 in “git submodule should honor "-c credential.helper" command line argument”
  1. Marc StrapetzFeb 2, 2016
  2. Jeff KingFeb 3, 2016
  3. Jacob KellerFeb 3, 2016
  4. Marc StrapetzFeb 3, 2016
  5. Jacob KellerFeb 3, 2016
  6. Jacob KellerFeb 7, 2016
  7. Marc StrapetzFeb 7, 2016
  8. Jacob KellerFeb 8, 2016
  9. Jacob KellerFeb 19, 2016
  10. Jeff KingFeb 19, 2016
  11. Jacob KellerFeb 19, 2016
  12. Jeff KingFeb 19, 2016
  13. Jacob KellerFeb 19, 2016
  14. Junio C HamanoFeb 19, 2016
  15. Jacob KellerFeb 19, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.