Re: git submodule should honor "-c credential.helper" command line argument
- From
Jacob Keller <jacob.keller@gmail.com>
- Date
- Feb 7, 2016, 04:41 UTC
- Message-ID
- <CA+P7+xr4gQFPsUiuqSzMsUJP6_W8FnXBwX1Xes=XjksuTs=+hQ@mail.gmail.com>
- In-Reply-To
- <CA+P7+xpGTvbyLOKQ=DHFBLOuVNN8WocraaZQhFD36oDiFrY+sA@mail.gmail.com>
On Wed, Feb 3, 2016 at 3:44 PM, Jacob Keller <jacob.keller@gmail.com> wrote:
Show 10 quoted lines
> Ok so I am not sure we even really need to use "-c" option in > git-clone considering that we can just use the same flow we do for > setting core.worktree values. I'll propose a patch with you two Cc'ed, > which I think fixes the issue. There may actually be a set of > configuration we want to include though, and the main issue I see is > that it won't get updated correctly whenever the parent configuration > changes. > > Thanks, > Jake
I tried adding the config as part of module_clone in submodule--helper.c but it didn't pass the test I added. I haven't had time to look at this in the last few days, but I am stuck as to why submodule--helper.c appeared to not use module_clone as I thought.
Regards, Jake