git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git submodule should honor "-c credential.helper" command line argument

From
Jacob Keller <jacob.keller@gmail.com>
Date
Feb 19, 2016, 19:34 UTC
Message-ID
<CA+P7+xqyD=oOnZ+T_L29KYyS4EpmAAVda33ypTphFuPMbvyNRw@mail.gmail.com>
In-Reply-To
<xmqqr3g8d2pn.fsf@gitster.mtv.corp.google.com>
On Fri, Feb 19, 2016 at 9:33 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 10 quoted lines
> Jeff King <peff@peff.net> writes:
>
>> That being said, I am not sure this is the right solution. In the thread
>> I linked earlier[1], Jens indicated he would prefer not to blindly share
>> config with the submodules, and I think I agree. Or are you proposing to
>> pick and choose the keys in GIT_CONFIG_PARAMETERS, and whitelist
>> credential.*?
>
> Yes, I think it is sensible not to propagate by default, and pass
> ones that are absolutely safe, sane and necessary by whitelisting.

Yes I agree. I'm trying to think of a reasonable way to implement this as part of a submodule--helper.. something like whitelist-config or something, which would just output the value of GIT_CONFIG_PARAMETERS after whitelisting. It would be up to the shell code to then use this inside a subshell.

Regards, Jake

Previous: Junio C Hamano
Message 15 of 15 in “git submodule should honor "-c credential.helper" command line argument”
  1. Marc StrapetzFeb 2, 2016
  2. Jeff KingFeb 3, 2016
  3. Jacob KellerFeb 3, 2016
  4. Marc StrapetzFeb 3, 2016
  5. Jacob KellerFeb 3, 2016
  6. Jacob KellerFeb 7, 2016
  7. Marc StrapetzFeb 7, 2016
  8. Jacob KellerFeb 8, 2016
  9. Jacob KellerFeb 19, 2016
  10. Jeff KingFeb 19, 2016
  11. Jacob KellerFeb 19, 2016
  12. Jeff KingFeb 19, 2016
  13. Jacob KellerFeb 19, 2016
  14. Junio C HamanoFeb 19, 2016
  15. Jacob KellerFeb 19, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.