Re: [PATCH 4/6] t1500: avoid setting configuration options outside of tests

From: Junio C Hamano <gitster@pobox.com>
Date: May 10, 2016, 18:02 UTC
Message-ID: <xmqqr3d9pz9k.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAPig+cTXOcUfO=EE5xhOjEgzSNtmhrD84PDMvVHX9hEmwuV==g@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 11 quoted lines

>> diff --git a/t/t1500-rev-parse.sh b/t/t1500-rev-parse.sh
>> @@ -6,15 +6,25 @@ test_description='test git rev-parse'
>> +       case "$bare" in
>> ...
>> +       u*) bare="test_unconfig $dir core.bare" ;;
>> +       *) error "test_rev_parse: unrecognized core.bare value '$bare'"
>
> Oops, this line lost its ;; at some point while refining the code.
>
>> +       esac
>> +

Strictly speaking, you do not have to have one. I'll squeeze it in anyways.