Re: [PATCH 0/6] modernize t1500
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 10, 2016, 18:26 UTC
- Message-ID
- <xmqqeg99py5j.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <xmqqmvnxpyw6.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 27 quoted lines
> Junio C Hamano <gitster@pobox.com> writes: > >> Eric Sunshine <sunshine@sunshineco.com> writes: >> >>> This series modernizes t1500; it takes an entirely different approach >>> than [1][2] and is intended to replace that series. >> >> Turns out that it wasn't so painful after all. >> >> The only small niggle I have is on 6/6; my preference would be, >> because once we set up .git we do not add objects and refs to it, to >> make a copy a lot earlier before the tests start. > > -- >8 -- > Subject: [PATCH 7/6] t1500: finish preparation upfront > > The earlier tests do not attempt to modify the contents of .git (by > creating objects or refs, for example), which means that even if > some earlier tests before "cp -R" fail, the tests in repo.git will > run in an environment that we can expect them to succeed in. > > Make it clear that tests in repo.git will be independent from the > results of earlier tests done in .git by moving its initialization > "cp -R .git repo.git" much higher in the test sequence. > > Signed-off-by: Junio C Hamano <gitster@pobox.com> > ---
I think the same logic applies to other preparatory things like creation of sub/dir in the working tree etc.