Re: [PATCH 0/6] modernize t1500
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 10, 2016, 18:10 UTC
- Message-ID
- <xmqqmvnxpyw6.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <xmqqfutqsaxn.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 10 quoted lines
> Eric Sunshine <sunshine@sunshineco.com> writes: > >> This series modernizes t1500; it takes an entirely different approach >> than [1][2] and is intended to replace that series. > > Turns out that it wasn't so painful after all. > > The only small niggle I have is on 6/6; my preference would be, > because once we set up .git we do not add objects and refs to it, to > make a copy a lot earlier before the tests start.
-- >8 -- Subject: [PATCH 7/6] t1500: finish preparation upfront
The earlier tests do not attempt to modify the contents of .git (by creating objects or refs, for example), which means that even if some earlier tests before "cp -R" fail, the tests in repo.git will run in an environment that we can expect them to succeed in.
Make it clear that tests in repo.git will be independent from the results of earlier tests done in .git by moving its initialization "cp -R .git repo.git" much higher in the test sequence.
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- t/t1500-rev-parse.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/t/t1500-rev-parse.sh b/t/t1500-rev-parse.sh index 811c70f2..cb08677 100755 --- a/t/t1500-rev-parse.sh +++ b/t/t1500-rev-parse.sh @@ -51,6 +51,7 @@ test_rev_parse () { } ROOT=$(pwd) +test_expect_success 'setup non-local database ../repo.git' 'cp -R .git repo.git' test_rev_parse toplevel false false true '' .git @@ -72,8 +73,6 @@ test_rev_parse -C work -g ../.git -b t 'GIT_DIR=../.git, core.bare = true' true test_rev_parse -C work -g ../.git -b u 'GIT_DIR=../.git, core.bare undefined' false false true '' -test_expect_success 'setup non-local database ../repo.git' 'cp -R .git repo.git' - test_rev_parse -C work -g ../repo.git -b f 'GIT_DIR=../repo.git, core.bare = false' false false true '' test_rev_parse -C work -g ../repo.git -b t 'GIT_DIR=../repo.git, core.bare = true' true false false ''
-- 2.8.2-623-gacdd3f1