Re: [PATCH 00/27] nd/shallow-deepen updates
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 13, 2016, 17:10 UTC
- Message-ID
- <xmqqr3c1c8we.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <CAPig+cRfUjpku1Abf=GxrbFeS4txwr=yZsJ7EKo-aWmxYog6Xw@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
> I agree with Junio that moving the sigchain_pop() into the error > handling code-path, if possible, would be a nice improvement.
Yeah, "if possible" is really what I was not sure about---is it safe to do the _push() thing before start_command(), which presumably would affect both the main and the forked processes?