git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 11/27] fetch-pack: use skip_prefix() instead of starts_with()

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Jun 12, 2016, 10:53 UTC
Message-ID
<20160612105409.22156-12-pclouds@gmail.com>
In-Reply-To
<20160612105409.22156-1-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 builtin/fetch-pack.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/builtin/fetch-pack.c b/builtin/fetch-pack.c
index 9b2a514..8332d3d 100644
--- a/builtin/fetch-pack.c
+++ b/builtin/fetch-pack.c
@@ -59,12 +59,12 @@ int cmd_fetch_pack(int argc, const char **argv, const char *prefix)
 	for (i = 1; i < argc && *argv[i] == '-'; i++) {
 		const char *arg = argv[i];
 
-		if (starts_with(arg, "--upload-pack=")) {
-			args.uploadpack = arg + 14;
+		if (skip_prefix(arg, "--upload-pack=", &arg)) {
+			args.uploadpack = arg;
 			continue;
 		}
-		if (starts_with(arg, "--exec=")) {
-			args.uploadpack = arg + 7;
+		if (skip_prefix(arg, "--exec=", &arg)) {
+			args.uploadpack = arg;
 			continue;
 		}
 		if (!strcmp("--quiet", arg) || !strcmp("-q", arg)) {
@@ -100,8 +100,8 @@ int cmd_fetch_pack(int argc, const char **argv, const char *prefix)
 			args.verbose = 1;
 			continue;
 		}
-		if (starts_with(arg, "--depth=")) {
-			args.depth = strtol(arg + 8, NULL, 0);
+		if (skip_prefix(arg, "--depth=", &arg)) {
+			args.depth = strtol(arg, NULL, 0);
 			continue;
 		}
 		if (!strcmp("--no-progress", arg)) {
-- 
2.8.2.524.g6ff3d78
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 47 of 64 in “nd/shallow-deepen updates”
  1. 00/27 nd/shallow-deepen updatesNguyễn Thái Ngọc Duy, Jun 10, 2016
  2. 08/27 upload-pack: tighten number parsing at "deepen" linesNguyễn Thái Ngọc Duy, Jun 10, 2016
  3. 09/27 upload-pack: make check_non_tip() clean things up errorNguyễn Thái Ngọc Duy, Jun 10, 2016
  4. Junio C HamanoJun 10, 2016
  5. 05/27 upload-pack: remove unused variable "backup"Nguyễn Thái Ngọc Duy, Jun 10, 2016
  6. Junio C HamanoJun 10, 2016
  7. 12/27 fetch-pack: use a common function for verbose printingNguyễn Thái Ngọc Duy, Jun 10, 2016
  8. 04/27 upload-pack: move "shallow" sending code out of deepen()Nguyễn Thái Ngọc Duy, Jun 10, 2016
  9. Junio C HamanoJun 10, 2016
  10. 11/27 fetch-pack: use skip_prefix() instead of starts_with()Nguyễn Thái Ngọc Duy, Jun 10, 2016
  11. 06/27 upload-pack: move "unshallow" sending code out of deepen()Nguyễn Thái Ngọc Duy, Jun 10, 2016
  12. Junio C HamanoJun 10, 2016
  13. 03/27 upload-pack: move shallow deepen code out of receive_needs()Nguyễn Thái Ngọc Duy, Jun 10, 2016
  14. 02/27 transport-helper.c: refactor set_helper_option()Nguyễn Thái Ngọc Duy, Jun 10, 2016
  15. 01/27 remote-curl.c: convert fetch_git() to use argv_arrayNguyễn Thái Ngọc Duy, Jun 10, 2016
  16. 07/27 upload-pack: use skip_prefix() instead of starts_with()Nguyễn Thái Ngọc Duy, Jun 10, 2016
  17. 10/27 upload-pack: move rev-list code out of check_non_tip()Nguyễn Thái Ngọc Duy, Jun 10, 2016
  18. Junio C HamanoJun 10, 2016
  19. 25/27 upload-pack: split check_unreachable() in two, prep for get_reachable_list()Nguyễn Thái Ngọc Duy, Jun 10, 2016
  20. 16/27 upload-pack: add deepen-since to cut shallow repos based on timeNguyễn Thái Ngọc Duy, Jun 10, 2016
  21. 17/27 fetch: define shallow boundary with --shallow-sinceNguyễn Thái Ngọc Duy, Jun 10, 2016
  22. 18/27 clone: define shallow clone boundary based on time with --shallow-sinceNguyễn Thái Ngọc Duy, Jun 10, 2016
  23. 24/27 t5500, t5539: tests for shallow depth excluding a refNguyễn Thái Ngọc Duy, Jun 10, 2016
  24. 23/27 clone: define shallow clone boundary with --shallow-excludeNguyễn Thái Ngọc Duy, Jun 10, 2016
  25. 21/27 upload-pack: support define shallow boundary by excluding revisionsNguyễn Thái Ngọc Duy, Jun 10, 2016
  26. 26/27 upload-pack: add get_reachable_list()Nguyễn Thái Ngọc Duy, Jun 10, 2016
  27. 27/27 fetch, upload-pack: --deepen=N extends shallow boundary by N commitsNguyễn Thái Ngọc Duy, Jun 10, 2016
  28. 22/27 fetch: define shallow boundary with --shallow-excludeNguyễn Thái Ngọc Duy, Jun 10, 2016
  29. 14/27 fetch-pack: use a separate flag for fetch in deepening modeNguyễn Thái Ngọc Duy, Jun 10, 2016
  30. 20/27 refs: add expand_ref()Nguyễn Thái Ngọc Duy, Jun 10, 2016
  31. 19/27 t5500, t5539: tests for shallow depth since a specific dateNguyễn Thái Ngọc Duy, Jun 10, 2016
  32. 15/27 shallow.c: implement a generic shallow boundary finder based on rev-listNguyễn Thái Ngọc Duy, Jun 10, 2016
  33. 13/27 fetch-pack.c: mark strings for translatingNguyễn Thái Ngọc Duy, Jun 10, 2016
  34. Eric SunshineJun 10, 2016
  35. Junio C HamanoJun 13, 2016
  36. Duy NguyenJun 14, 2016
  37. 00/27 nd/shallow-deepen updatesNguyễn Thái Ngọc Duy, Jun 12, 2016
  38. 01/27 remote-curl.c: convert fetch_git() to use argv_arrayNguyễn Thái Ngọc Duy, Jun 12, 2016
  39. 02/27 transport-helper.c: refactor set_helper_option()Nguyễn Thái Ngọc Duy, Jun 12, 2016
  40. 03/27 upload-pack: move shallow deepen code out of receive_needs()Nguyễn Thái Ngọc Duy, Jun 12, 2016
  41. 05/27 upload-pack: remove unused variable "backup"Nguyễn Thái Ngọc Duy, Jun 12, 2016
  42. 04/27 upload-pack: move "shallow" sending code out of deepen()Nguyễn Thái Ngọc Duy, Jun 12, 2016
  43. 06/27 upload-pack: move "unshallow" sending code out of deepen()Nguyễn Thái Ngọc Duy, Jun 12, 2016
  44. 07/27 upload-pack: use skip_prefix() instead of starts_with()Nguyễn Thái Ngọc Duy, Jun 12, 2016
  45. 08/27 upload-pack: tighten number parsing at "deepen" linesNguyễn Thái Ngọc Duy, Jun 12, 2016
  46. 09/27 upload-pack: make check_non_tip() clean things up on errorNguyễn Thái Ngọc Duy, Jun 12, 2016
  47. 11/27 fetch-pack: use skip_prefix() instead of starts_with()Nguyễn Thái Ngọc Duy, Jun 12, 2016
  48. 10/27 upload-pack: move rev-list code out of check_non_tip()Nguyễn Thái Ngọc Duy, Jun 12, 2016
  49. 12/27 fetch-pack: use a common function for verbose printingNguyễn Thái Ngọc Duy, Jun 12, 2016
  50. 13/27 fetch-pack.c: mark strings for translatingNguyễn Thái Ngọc Duy, Jun 12, 2016
  51. 14/27 fetch-pack: use a separate flag for fetch in deepening modeNguyễn Thái Ngọc Duy, Jun 12, 2016
  52. 15/27 shallow.c: implement a generic shallow boundary finder based on rev-listNguyễn Thái Ngọc Duy, Jun 12, 2016
  53. 16/27 upload-pack: add deepen-since to cut shallow repos based on timeNguyễn Thái Ngọc Duy, Jun 12, 2016
  54. 17/27 fetch: define shallow boundary with --shallow-sinceNguyễn Thái Ngọc Duy, Jun 12, 2016
  55. 18/27 clone: define shallow clone boundary based on time with --shallow-sinceNguyễn Thái Ngọc Duy, Jun 12, 2016
  56. 20/27 refs: add expand_ref()Nguyễn Thái Ngọc Duy, Jun 12, 2016
  57. 19/27 t5500, t5539: tests for shallow depth since a specific dateNguyễn Thái Ngọc Duy, Jun 12, 2016
  58. 22/27 fetch: define shallow boundary with --shallow-excludeNguyễn Thái Ngọc Duy, Jun 12, 2016
  59. 21/27 upload-pack: support define shallow boundary by excluding revisionsNguyễn Thái Ngọc Duy, Jun 12, 2016
  60. 24/27 t5500, t5539: tests for shallow depth excluding a refNguyễn Thái Ngọc Duy, Jun 12, 2016
  61. 23/27 clone: define shallow clone boundary with --shallow-excludeNguyễn Thái Ngọc Duy, Jun 12, 2016
  62. 25/27 upload-pack: split check_unreachable() in two, prep for get_reachable_list()Nguyễn Thái Ngọc Duy, Jun 12, 2016
  63. 26/27 upload-pack: add get_reachable_list()Nguyễn Thái Ngọc Duy, Jun 12, 2016
  64. 27/27 fetch, upload-pack: --deepen=N extends shallow boundary by N commitsNguyễn Thái Ngọc Duy, Jun 12, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.