Re: [PATCH 00/27] nd/shallow-deepen updates

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jun 10, 2016, 23:42 UTC
Message-ID: <CAPig+cRfUjpku1Abf=GxrbFeS4txwr=yZsJ7EKo-aWmxYog6Xw@mail.gmail.com>
In-Reply-To: <20160610122714.3341-1-pclouds@gmail.com>

On Fri, Jun 10, 2016 at 8:26 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:

> This contains cleanups after Eric's comments (all good points,
> thanks!). Changed patches have Junio's s-o-b line removed, so it's
> easy to see which is changed and which is not. 09/27 is a new one,
> split out of 10/27.

Thanks, the interdiff looks sensible and I think it covers all the points raised by my review of the previous round.

I agree with Junio that moving the sigchain_pop() into the error handling code-path, if possible, would be a nice improvement.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.