Re: [PATCH v3 0/3] Introduce log.showSignature config variable
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 22, 2016, 20:31 UTC
- Message-ID
- <xmqqr3bpklsd.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20160622165126.12786-1-mehul.jain2029@gmail.com>
Mehul Jain <mehul.jain2029@gmail.com> writes:
Show 7 quoted lines
> Add a new configuratation variable "log.showSignature" for git-log > and related commands. "log.showSignature=true" will enable user to > see GPG signature by default for git-log and related commands. > > Changes compared to v2: > * A preparatory patch 1/3 has been introduced so that tests > in patches 2/3 and 3/3 can take advantage of it.
It is unclear how this change allows the remainder to "take advanrage" to me. Earlier, "signed" branch was created only when the GPG prerequisite is met and with this change the branch is always created, which is the only change as far as I can see. But the tests that are added in 2 and 3 are all protected with the GPG prerequiste.
Besides, the invocation of "git commit -S" after this change is no longer protected by the GPG prerequisite and it may even cause the 'setup' step to fail on a host without GPG.
What am I missing? I do not quite see any reason to take 1/2; I only see a possible downside without any upside.
The main two steps 2&3 looked good.
Thanks.
Show 7 quoted lines
> * Mistake regarding branch in [patch v2 2/2] has been > corrected. > * Tight coupling between the tests in [patch v2 2/2] has > been resovled. > > I would like to thanks Eric Sunshine for his feedback on previous > series [1].
Show 14 quoted lines
> > [1]: http://thread.gmane.org/gmane.comp.version-control.git/297648 > > Mehul Jain (3): > t4202: refactoring of test > log: add "--no-show-signature" command line option > log: add log.showSignature configuration variable > > Documentation/git-log.txt | 4 ++++ > builtin/log.c | 6 ++++++ > revision.c | 2 ++ > t/t4202-log.sh | 32 ++++++++++++++++++++++++++++++-- > t/t7510-signed-commit.sh | 7 +++++++ > 5 files changed, 49 insertions(+), 2 deletions(-)