git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 1/3] t4202: refactor test

From
Mehul Jain <mehul.jain2029@gmail.com>
Date
Jun 24, 2016, 14:12 UTC
Message-ID
<20160624141234.22836-1-mehul.jain2029@gmail.com>
In-Reply-To
<20160622165126.12786-2-mehul.jain2029@gmail.com>

Subsequent patches will want to reuse the 'signed' branch that the 'log --graph --show-signature' test creates and uses.

Split the set-up part into a test of its own, and make the existing test into a separate one that only inspects the history on the 'signed' branch. This way, it becomes clearer that tests added by subsequent patches reuse the 'signed' branch in the same way.

Signed-off-by: Mehul Jain <mehul.jain2029@gmail.com>
---
 t/t4202-log.sh | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/t/t4202-log.sh b/t/t4202-log.sh
index 128ba93..ab66ee0 100755
--- a/t/t4202-log.sh
+++ b/t/t4202-log.sh
@@ -860,12 +860,15 @@ test_expect_success 'dotdot is a parent directory' '
 	test_cmp expect actual
 '
 
-test_expect_success GPG 'log --graph --show-signature' '
+test_expect_success GPG 'setup signed branch' '
 	test_when_finished "git reset --hard && git checkout master" &&
 	git checkout -b signed master &&
 	echo foo >foo &&
 	git add foo &&
-	git commit -S -m signed_commit &&
+	git commit -S -m signed_commit
+'
+
+test_expect_success GPG 'log --graph --show-signature' '
 	git log --graph --show-signature -n1 signed >actual &&
 	grep "^| gpg: Signature made" actual &&
 	grep "^| gpg: Good signature" actual
-- 
2.9.0.rc0.dirty
Previous: Mehul JainNext: Mehul Jain
Message 3 of 10 in “Introduce log.showSignature config variable”
  1. 0/3 Introduce log.showSignature config variableMehul Jain, Jun 22, 2016
  2. 1/3 t4202: refactor testMehul Jain, Jun 22, 2016
  3. 1/3 t4202: refactor testMehul Jain, Jun 24, 2016
  4. 2/3 log: add "--no-show-signature" command line optionMehul Jain, Jun 22, 2016
  5. 3/3 log: add log.showSignature configuration variableMehul Jain, Jun 22, 2016
  6. Junio C HamanoJun 22, 2016
  7. Mehul JainJun 23, 2016
  8. Junio C HamanoJun 23, 2016
  9. Mehul JainJun 24, 2016
  10. Eric SunshineJun 24, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.