Re: [PATCH v3 0/3] Introduce log.showSignature config variable

From: Mehul Jain <mehul.jain2029@gmail.com>
Date: Jun 24, 2016, 09:21 UTC
Message-ID: <CA+DCAeSvb14W5CoEa72DQtM+FHQ+jppSVvoTmQ7rX0EHQAMy6g@mail.gmail.com>
In-Reply-To: <xmqqd1n8jtzk.fsf@gitster.mtv.corp.google.com>

On Thu, Jun 23, 2016 at 12:02 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

> Mehul Jain <mehul.jain2029@gmail.com> writes:
>
>> In patch 2/3 and 3/3, there are many tests which requires a branch
>> similar to that of "signed" branch, i.e. a branch with a commit having
>> GPG signature. So previously in v2, I created two new branches,
>> "test_sign" and "no_sign", which are identical to that of "signed"
>> branch. And with these branches, I wrote the tests in patch 2/3
>> and 3/3.
>>
>> As suggested by Eric [1], rather than creating new branches, I
>> can take advantage of "signed" branch which already exists.
>
> Yeah, I understand that part.  But you do not _need_ to do the split
> you do in 1/3 in order to reuse "signed".

If it's fine, then I think it would be OK to drop this 1/3. Without splitting the 'log --graph --show-signature' in two test will also serve the purpose for the new test to use the signed branch.

Should I send a new patch series with 1/3 dropped or you can do it manually at your end?

Thanks, Mehul