Re: [PATCH] compat: Allow static initializer for pthreads on Windows
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 28, 2016, 20:29 UTC
- Message-ID
- <xmqqr370z07v.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <38b70094-5550-8512-7735-a6739f435803@kdbg.org>
Johannes Sixt <j6t@kdbg.org> writes:
Show 7 quoted lines
> Another problem with the proposed patch is that there is no > declaration for attr_start() before the call in compat/mingw.c. We > would have to move the declaration of attr_start() to cache.h (for > example), because #including attr.h in compat/mingw.c is plainly > wrong. However, it would not be a major offense to #include attr.h in > common-main.c. But when we do that, we can certainly spare the few > cycles to call pthread_mutex_init.
That sounds like a good argument to have it in common-main.c.
Would it mean that the code that defines the mutex needs to have #ifdef that defines a no-op attr_start() and defines the mutex with PTHREAD_MUTEX_INITILIZER with #else that just defines the mutex without initializatin, with the real attr_start(), though?