Re: [PATCH] compat: Allow static initializer for pthreads on Windows
- From
Jacob Keller <jacob.keller@gmail.com>
- Date
- Oct 28, 2016, 18:48 UTC
- Message-ID
- <CA+P7+xoyF8EG079eC-dfTSj+YrbxhPWx356-jZ90gDs6SwyppA@mail.gmail.com>
- In-Reply-To
- <alpine.DEB.2.20.1610281356310.3264@virtualbox>
On Fri, Oct 28, 2016 at 4:58 AM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 13 quoted lines
> Hi Jake, > > On Thu, 27 Oct 2016, Jacob Keller wrote: > >> I agree with Stefan that there isn't really a great place to put a >> dynamic initialization. > > Ummm. Wait. What??? > > https://github.com/git/git/blob/v2.10.1/common-main.c#L25-L41 > > Ciao, > Johannes
I think Stefan has since provided a better suggestion of isolating the dynamic initialization into the MINGW startup section. However, you are right either place works, though I think platforms which support static initialization should use it.
Thanks, Jake