Re: [PATCH] compat: Allow static initializer for pthreads on Windows
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 27, 2016, 06:02 UTC
- Message-ID
- <xmqqlgxa8h3a.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <93be5d21-6cb6-ee2b-9f4f-c2fe7c690d6c@kdbg.org>
Johannes Sixt <j6t@kdbg.org> writes:
Show 10 quoted lines
> Am 26.10.2016 um 23:57 schrieb Stefan Beller: >> In Windows it is not possible to have a static initialized mutex as of >> now, but that seems to be painful for the upcoming refactoring of the >> attribute subsystem, as we have no good place to put the initialization >> of the attr global lock. > > Please rewrite the attribute system such that it can have a dynamic > initialization. If you find a global initialization in main() too > gross (I would agree) then setup_git_directory() might be the right > place.
As many codepaths may not even need access to the attributes, I doubt that would be a very productive direction to go.