Re: [PATCH] refs.c: use skip_prefix() in prettify_refname()

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 23, 2017, 19:40 UTC
Message-ID: <xmqqr31nbx3h.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <4424eeeb-7eea-ed41-c031-ba7915cb93ab@web.de>

René Scharfe <l.s.r@web.de> writes:

Show 14 quoted lines

>> I think René meant this:
>>
>>      /* just for side effects */
>>      skip_prefix(name, "refs/heads/", &name) ||
>>      skip_prefix(name, "refs/tags/", &name) ||
>>      skip_prefix(name, "refs/remotes/", &name);
>>
>>      return name;
>>
>> which still short-sircuits, even though I do think it looks
>> strange; "correct but strange".
>
> Yes.  At least to me it looks less strange than the same lines wrapped
> in "if ... /* nothing */".

Yup, after looking at it again, it does not look so "strange" to me. I probably should have said "unusual but correct", not "correct but strange".