git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] refs.c: use skip_prefix() in prettify_refname()

From
SZEDER Gábor <szeder.dev@gmail.com>
Date
Mar 23, 2017, 15:50 UTC
Message-ID
<20170323155012.6148-1-szeder.dev@gmail.com>
This eliminates three magic numbers.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
---
 refs.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/refs.c b/refs.c
index e7606716d..0272e332c 100644
--- a/refs.c
+++ b/refs.c
@@ -366,11 +366,11 @@ int for_each_glob_ref(each_ref_fn fn, const char *pattern, void *cb_data)
 
 const char *prettify_refname(const char *name)
 {
-	return name + (
-		starts_with(name, "refs/heads/") ? 11 :
-		starts_with(name, "refs/tags/") ? 10 :
-		starts_with(name, "refs/remotes/") ? 13 :
-		0);
+	if (skip_prefix(name, "refs/heads/", &name) ||
+	    skip_prefix(name, "refs/tags/", &name) ||
+	    skip_prefix(name, "refs/remotes/", &name))
+		; /* nothing */
+	return name;
 }
 
 static const char *ref_rev_parse_rules[] = {
-- 
2.12.1.485.g1616aa492
Next: René Scharfe
Message 1 of 11 in “refs.c: use skip_prefix() in prettify_refname()”
  1. refs.c: use skip_prefix() in prettify_refname()SZEDER Gábor, Mar 23, 2017
  2. René ScharfeMar 23, 2017
  3. Jeff KingMar 23, 2017
  4. Stefan BellerMar 23, 2017
  5. Junio C HamanoMar 23, 2017
  6. René ScharfeMar 23, 2017
  7. Junio C HamanoMar 23, 2017
  8. Jeff KingMar 23, 2017
  9. Junio C HamanoMar 23, 2017
  10. SZEDER GáborMar 23, 2017
  11. René ScharfeMar 23, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.