Re: [PATCH] refs.c: use skip_prefix() in prettify_refname()

From: René Scharfe <l.s.r@web.de>
Date: Mar 23, 2017, 20:06 UTC
Message-ID: <83a38f4d-a80e-e41c-a563-05585377ac13@web.de>
In-Reply-To: <20170323193919.twwfwdoulo2hjz24@sigill.intra.peff.net>

Am 23.03.2017 um 20:39 schrieb Jeff King:

Show 19 quoted lines

> On Thu, Mar 23, 2017 at 12:33:06PM -0700, Junio C Hamano wrote:
>
>>>> Nice, but why add the "if" when it's doing nothing?
>>>
>>> It's short-circuiting in the conditional.
>>
>> I think René meant this:
>>
>>      /* just for side effects */
>>      skip_prefix(name, "refs/heads/", &name) ||
>>      skip_prefix(name, "refs/tags/", &name) ||
>>      skip_prefix(name, "refs/remotes/", &name);
>>
>>      return name;
>>
>> which still short-sircuits, even though I do think it looks
>> strange; "correct but strange".
>
> And it causes the compiler to complain that the value is not used.

Ah, that explains it, thanks. The "if" is strange, but wrapping the expression in (void)(...) isn't better.

Clang doesn't warn about the code above by the way.

René