Re: Bug report: git clone with dest
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 5, 2018, 20:38 UTC
- Message-ID
- <xmqqr2r4avnu.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <nycvar.QRO.7.76.6.1801052118410.1337@wbunaarf-fpuvaqryva.tvgsbejvaqbjf.bet>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 26 quoted lines
> Hi Isaac, > > On Fri, 5 Jan 2018, Isaac Shabtay wrote: > >> Done: https://github.com/git-for-windows/git/pull/1421 >> >> I added credit to Jeff in the PR's description. > > Sadly, the PR's description won't make it into the commit history, and the > authorship really should have been retained. > > I found Peff's topic branch in his fork and force-pushed, to demonstrate > what I wanted to have. Currently the test suite is running (I test 64-bit > builds of the three major platforms Windows, macOS and Linux), and once > that is done and passed, I will merge the Pull Request. > >> Note that I tried compiling master, but failed due to a reason >> unrelated to this patch: >> >> builtin/checkout.c:24:10: fatal error: fscache.h: No such file or directory > > That was an oversight in a previously-merged Pull Request. I have fixed > that locally and will soon push it out onto `master`. > > Ciao, > Johannes
FWIW, I do not mind including this as part of -rc2 if not -rc1 for the upcoming release.