Re: Bug report: git clone with dest

From: Isaac Shabtay <isaac@shabtay.com>
Date: Jan 5, 2018, 05:11 UTC
Message-ID: <CAK2k7nTRAqQKFGi0OfVgub3vWZAkdML5p786L7UyhVDFtsk7Xg@mail.gmail.com>
In-Reply-To: <alpine.DEB.2.21.1.1801050019250.32@MININT-6BKU6QN.europe.corp.microsoft.com>

Hello Johannes, Jeff,

I cloned git's codebase, applied the four patches on master, built and tested on Ubuntu Trusty. (After verifying that master indeed exhibits this behaviour on Linux as well. Just checking). Seems to work fine. I also looked at the code. Most of the patched lines relate to tests, and the one for clone.c seems reasonable to me. Added tests seem to have very good coverage too.

I qualify everything I had written above by saying that it's my first time ever looking at Git's source code.

On 4 January 2018 at 15:20, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 14 quoted lines

> Hi Isaac,
>
> On Wed, 3 Jan 2018, Isaac Shabtay wrote:
>
>> Indeed interesting... this one's for the books...
>> Thanks for the patches. Any idea when these are going to make it to
>> the official Git client builds? (specifically the Windows one)
>
> If you help them getting reviewed, tested, and validated, I could be
> talked into taking them into Git for Windows early so that they'll be in
> Git for Windows v2.16.0. It will require your effort, though.
>
> Ciao,
> Johannes