Re: Bug report: git clone with dest

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 5, 2018, 10:33 UTC
Message-ID: <alpine.DEB.2.21.1.1801051130500.32@MININT-6BKU6QN.europe.corp.microsoft.com>
In-Reply-To: <CAK2k7nTRAqQKFGi0OfVgub3vWZAkdML5p786L7UyhVDFtsk7Xg@mail.gmail.com>

Hi Isaac,

On Thu, 4 Jan 2018, Isaac Shabtay wrote:

Show 7 quoted lines

> I cloned git's codebase, applied the four patches on master, built and
> tested on Ubuntu Trusty. (After verifying that master indeed exhibits
> this behaviour on Linux as well. Just checking).
> Seems to work fine.
> I also looked at the code. Most of the patched lines relate to tests,
> and the one for clone.c seems reasonable to me. Added tests seem to
> have very good coverage too.

Thanks.

> I qualify everything I had written above by saying that it's my first
> time ever looking at Git's source code.

We all started at some point.

Now, if you want to make this easier for me, could you please apply those patches on top of Git for Windows' master branch and open a Pull Request at https://github.com/git-for-windows/git?

Thank you, Johannes