Re: [PATCH v4] filter-branch: fix errors caused by refs that point at non-committish
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 8, 2018, 23:10 UTC
- Message-ID
- <xmqqr2np8fb6.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <5ab7d550.dc96620a.4b512.feab@mx.google.com>
Yuki Kokubun <orga.chem.job@gmail.com> writes:
Show 5 quoted lines
> References: <1521996898-7052-1-git-send-email-orga.chem.job@gmail.com> > Content-Type: text/plain > > Sorry, I forgot add a line of "Reviewed-by". > I'm gonna send the fixed patch again.
Do not worry too much about this. Reviewed-by: added by patch author is seen rather rarely, because the following sequence of events need to happen:
- The author sends a patch vN
- A reviewer reviews vN and says "This is now Reviewed-by: me"
- The author re-submits patch vN+1, where the only difference between vN and vN+1 is essentially _nothing_. Except for the addition of "Reviewed-by:" by the reviewer.
But our typical patch injestion cycle is much faster and often the last step does not happen ;-)