[PATCH] filter-branch: consider refs can refer to an object other than commit or tag
- From
Yuki Kokubun <orga.chem.job@gmail.com>
- Date
- Mar 21, 2018, 15:31 UTC
- Message-ID
- <1521646299-16193-1-git-send-email-orga.chem.job@gmail.com>
- In-Reply-To
- <20180321103504.9483-1-orga.chem.job@gmail.com>
"git filter-branch -- --all" can be confused when refs that refer to objects other than commits or tags exists. Because "git rev-parse --all" that is internally used can return refs that refer to an object other than commit or tag. But it is not considered in the phase of updating refs. Such refs can be created by "git replace" with objects other than commits or trees.
Signed-off-by: Yuki Kokubun <orga.chem.job@gmail.com> --- This patch fix the bug of the first patch. The first patch did not consider tags.
git-filter-branch.sh | 11 ++++++++++- t/t7003-filter-branch.sh | 13 +++++++++++++ 2 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/git-filter-branch.sh b/git-filter-branch.sh index 1b7e4b2cd..f7cd97b86 100755 --- a/git-filter-branch.sh +++ b/git-filter-branch.sh @@ -251,7 +251,16 @@ done < "$tempdir"/backup-refs # The refs should be updated if their heads were rewritten git rev-parse --no-flags --revs-only --symbolic-full-name \ - --default HEAD "$@" > "$tempdir"/raw-heads || exit + --default HEAD "$@" > "$tempdir"/raw-objects || exit +# refs/replace can refer to an object other than commit or tag +while read ref +do + type=$(git cat-file -t "$ref") + if test $type = commit || test $type = tag + then + echo "$ref" + fi +done >"$tempdir"/raw-heads <"$tempdir"/raw-objects sed -e '/^^/d' "$tempdir"/raw-heads >"$tempdir"/heads test -s "$tempdir"/heads || diff --git a/t/t7003-filter-branch.sh b/t/t7003-filter-branch.sh index 7cb60799b..efeaf5887 100755 --- a/t/t7003-filter-branch.sh +++ b/t/t7003-filter-branch.sh @@ -470,4 +470,17 @@ test_expect_success 'tree-filter deals with object name vs pathname ambiguity' ' git show HEAD:$ambiguous ' +test_expect_success 'rewrite repository including refs/replace that point to non commit object' ' + test_when_finished "git reset --hard original" && + tree=$(git rev-parse HEAD^{tree}) && + test_when_finished "git replace -d $tree" && + echo A >new && + git add new && + new_tree=$(git write-tree) && + git replace $tree $new_tree && + git reset --hard HEAD && + git filter-branch -f -- --all >filter-output 2>&1 && + ! fgrep fatal filter-output +' + test_done
-- 2.16.2.18.g09cb46d