git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v1 0/8] Introducing odb remote

From
Junio C Hamano <gitster@pobox.com>
Date
May 14, 2018, 08:12 UTC
Message-ID
<xmqqr2mebqph.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20180513103232.17514-1-chriscool@tuxfamily.org>
Christian Couder <christian.couder@gmail.com> writes:
Show 6 quoted lines
> This is a follow up from the patch series called "Promisor remotes and
> external ODB support" that I sent earlier this year.
>
> Following discussions of these patch series, where Junio said "a
> minimum s/ext/remote/ would clarify what it is", I decided to rename
> "external odb" to "odb remote".

In "external odb", "odb" is a noun, decorated by adjective "external". I would expect the same would apply to "remote" and "odb".

Show 5 quoted lines
> I am still open to another name, but I
> think that "odb remote" works well with "odb helper" that was already
> used in the series and is as good or perhaps better than "remote odb",
> as a "remote odb" I think would be easier to confuse with a regular
> "remote".

As long as our use of "remote" as a noun is understood as omitting (an obvious) "repository" from a noun phrase "remote repository", I do not think there is any confusion.

"odb remote" sounds like the phrase is about a noun "remote" (we do use "remote" as a noun when talking about fetching and pushing, as a short hand for "remote repository") that uses "odb" as an adjective somehow (e.g. "this is one of those remotes defined but not for the usual fetching and pushing, but for accessing its odb", or something ilke that), which somehow does not sit well on my tongue nor in ears. Perhaps that is because I am not well versed in languages whose natural word order in a noun phrase is noun followed by adjective, but I dunno.

> Another obvious difference with the previous series is that this
> series is only about integrating with the promisor/narrow clone work
> and showing that it makes it possible to use more than one promisor
> remote.
Sounds like a sensible "incremental" approach.

Will read the patches and commet on them in another sitting. Thanks.

Previous: Christian Couder
Message 15 of 15 in “Introducing odb remote”
  1. 0/8 Introducing odb remoteChristian Couder, May 13, 2018
  2. 1/8 fetch-object: make functions return an error codeChristian Couder, May 13, 2018
  3. Junio C HamanoMay 15, 2018
  4. 3/8 odb-remote: implement odb_remote_get_direct()Christian Couder, May 13, 2018
  5. 5/8 odb-remote: add odb_remote_reinit()Christian Couder, May 13, 2018
  6. 2/8 Add initial odb remote supportChristian Couder, May 13, 2018
  7. Junio C HamanoMay 15, 2018
  8. Christian CouderJun 23, 2018
  9. Junio C HamanoJun 25, 2018
  10. Ævar Arnfjörð BjarmasonMay 15, 2018
  11. 7/8 Use odb.origin.partialclonefilter instead of core.partialclonefilterChristian Couder, May 13, 2018
  12. 6/8 Use odb_remote_get_direct() and has_external_odb()Christian Couder, May 13, 2018
  13. 8/8 t0410: test fetching from many promisor remotesChristian Couder, May 13, 2018
  14. 4/8 odb-remote: implement odb_remote_get_many_direct()Christian Couder, May 13, 2018
  15. Junio C HamanoMay 14, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.