git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v1 3/8] odb-remote: implement odb_remote_get_direct()

From
Christian Couder <christian.couder@gmail.com>
Date
May 13, 2018, 10:32 UTC
Message-ID
<20180513103232.17514-4-chriscool@tuxfamily.org>
In-Reply-To
<20180513103232.17514-1-chriscool@tuxfamily.org>

This is implemented only in the promisor remote mode for now by calling fetch_object().

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 odb-helper.c | 14 ++++++++++++++
 odb-helper.h |  3 ++-
 odb-remote.c | 17 +++++++++++++++++
 odb-remote.h |  1 +
 4 files changed, 34 insertions(+), 1 deletion(-)
diff --git a/odb-helper.c b/odb-helper.c
index b4d403ffa9..2851fe2657 100644
--- a/odb-helper.c
+++ b/odb-helper.c
@@ -4,6 +4,7 @@
 #include "odb-helper.h"
 #include "run-command.h"
 #include "sha1-lookup.h"
+#include "fetch-object.h"
 
 struct odb_helper *odb_helper_new(const char *name, int namelen)
 {
@@ -14,3 +15,16 @@ struct odb_helper *odb_helper_new(const char *name, int namelen)
 
 	return o;
 }
+
+int odb_helper_get_direct(struct odb_helper *o,
+			  const unsigned char *sha1)
+{
+	int res;
+	uint64_t start = getnanotime();
+
+	res = fetch_object(o->dealer, sha1);
+
+	trace_performance_since(start, "odb_helper_get_direct");
+
+	return res;
+}
diff --git a/odb-helper.h b/odb-helper.h
index 61d2ad082b..d21b625a7e 100644
--- a/odb-helper.h
+++ b/odb-helper.h
@@ -9,5 +9,6 @@ struct odb_helper {
 };
 
 extern struct odb_helper *odb_helper_new(const char *name, int namelen);
-
+extern int odb_helper_get_direct(struct odb_helper *o,
+				 const unsigned char *sha1);
 #endif /* ODB_HELPER_H */
diff --git a/odb-remote.c b/odb-remote.c
index e03b953ec6..dbab40c0f8 100644
--- a/odb-remote.c
+++ b/odb-remote.c
@@ -70,3 +70,20 @@ int has_odb_remote(void)
 {
 	return !!find_odb_helper(NULL);
 }
+
+int odb_remote_get_direct(const unsigned char *sha1)
+{
+	struct odb_helper *o;
+
+	trace_printf("trace: odb_remote_get_direct: %s", sha1_to_hex(sha1));
+
+	odb_remote_init();
+
+	for (o = helpers; o; o = o->next) {
+		if (odb_helper_get_direct(o, sha1) < 0)
+			continue;
+		return 0;
+	}
+
+	return -1;
+}
diff --git a/odb-remote.h b/odb-remote.h
index 68aa330244..27a480fcfe 100644
--- a/odb-remote.h
+++ b/odb-remote.h
@@ -3,5 +3,6 @@
 
 extern struct odb_helper *find_odb_helper(const char *dealer);
 extern int has_odb_remote(void);
+extern int odb_remote_get_direct(const unsigned char *sha1);
 
 #endif /* ODB_REMOTE_H */
-- 
2.17.0.590.gbd05bfcafd
Previous: Junio C HamanoNext: Christian Couder
Message 4 of 15 in “Introducing odb remote”
  1. 0/8 Introducing odb remoteChristian Couder, May 13, 2018
  2. 1/8 fetch-object: make functions return an error codeChristian Couder, May 13, 2018
  3. Junio C HamanoMay 15, 2018
  4. 3/8 odb-remote: implement odb_remote_get_direct()Christian Couder, May 13, 2018
  5. 5/8 odb-remote: add odb_remote_reinit()Christian Couder, May 13, 2018
  6. 2/8 Add initial odb remote supportChristian Couder, May 13, 2018
  7. Junio C HamanoMay 15, 2018
  8. Christian CouderJun 23, 2018
  9. Junio C HamanoJun 25, 2018
  10. Ævar Arnfjörð BjarmasonMay 15, 2018
  11. 7/8 Use odb.origin.partialclonefilter instead of core.partialclonefilterChristian Couder, May 13, 2018
  12. 6/8 Use odb_remote_get_direct() and has_external_odb()Christian Couder, May 13, 2018
  13. 8/8 t0410: test fetching from many promisor remotesChristian Couder, May 13, 2018
  14. 4/8 odb-remote: implement odb_remote_get_many_direct()Christian Couder, May 13, 2018
  15. Junio C HamanoMay 14, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.