[PATCH v1 0/8] Introducing odb remote

This is a follow up from the patch series called "Promisor remotes and external ODB support" that I sent earlier this year.

Following discussions of these patch series, where Junio said "a minimum s/ext/remote/ would clarify what it is", I decided to rename "external odb" to "odb remote". I am still open to another name, but I think that "odb remote" works well with "odb helper" that was already used in the series and is as good or perhaps better than "remote odb", as a "remote odb" I think would be easier to confuse with a regular "remote".

Another obvious difference with the previous series is that this series is only about integrating with the promisor/narrow clone work and showing that it makes it possible to use more than one promisor remote. Everything that is not necessary for that integration has been removed for now (though you can still find it in one of my branches on GitHub if you want).

This makes this patch series much shorter than the previous ones and already useful. So hopefully this will make it possible to start reviewing and merging it.

There is one test in patch 8/8 that shows that more than one promisor remote can now be used, but I feel that it could be interesting to add other such tests, so I am open to ideas in this area.

High level overview of this patch series ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  - Patch 1/8:

This makes functions in fetch-object.c return an error code, which is necessary to later tell that they failed and try another odb remote when there is more than one. This could also just be seen as a fix to these functions.

  - Patch 2/8:

This introduces the minimum infrastructure for odb remotes.

  - Patches 3/8 and 4/8:

These patches implement odb_remote_get_direct() and odb_remote_get_many_direct() using the functions from fetch-object.c. These new functions will be used in following patches to replace the functions from fetch-object.c.

  - Patch 5/8:

This implement odb_remote_reinit() which will be needed to reparse the odb remote configuration.

  - Patches 6/8 and 7/8:

These patches integrate the odb remote mechanism into the promisor/narrow clone code. The "extensions.partialclone" config option is replaced by "odb.<name>.promisorRemote" and "core.partialclonefilter" is replaced by "odb.<name>.partialclonefilter".

  - Patch 8/8:

This adds a test case that shows that now more than one promisor remote can be used.

Links ~~~~~

This patch series on GitHub:

https://github.com/chriscool/git/commits/odb-remote

Version 1 and 2 of the "Promisor remotes and external ODB support" series:

https://public-inbox.org/git/20180103163403.11303-1-chriscool@tuxfamily.org/ https://public-inbox.org/git/20180319133147.15413-1-chriscool@tuxfamily.org/

Version 1 and 2 of the "Promisor remotes and external ODB support" series on GitHub:

https://github.com/chriscool/git/commits/gl-small-promisor-external-odb12 https://github.com/chriscool/git/commits/gl-small-promisor-external-odb71

Christian Couder (8):
  fetch-object: make functions return an error code
  Add initial odb remote support
  odb-remote: implement odb_remote_get_direct()
  odb-remote: implement odb_remote_get_many_direct()
  odb-remote: add odb_remote_reinit()
  Use odb_remote_get_direct() and has_external_odb()
  Use odb.origin.partialclonefilter instead of core.partialclonefilter
  t0410: test fetching from many promisor remotes

 Makefile                      |   2 +
 builtin/cat-file.c            |   5 +-
 builtin/fetch.c               |  13 ++--
 builtin/gc.c                  |   3 +-
 builtin/repack.c              |   3 +-
 cache.h                       |   2 -
 connected.c                   |   3 +-
 environment.c                 |   1 -
 fetch-object.c                |  15 +++--
 fetch-object.h                |   6 +-
 list-objects-filter-options.c |  49 ++++++++------
 list-objects-filter-options.h |   3 +-
 odb-helper.c                  |  45 +++++++++++++
 odb-helper.h                  |  18 ++++++
 odb-remote.c                  | 118 ++++++++++++++++++++++++++++++++++
 odb-remote.h                  |  10 +++
 packfile.c                    |   3 +-
 setup.c                       |   7 +-
 sha1-file.c                   |   9 +--
 t/t0410-partial-clone.sh      |  54 +++++++++++-----
 t/t5500-fetch-pack.sh         |   4 +-
 t/t5601-clone.sh              |   2 +-
 t/t5616-partial-clone.sh      |   4 +-
 unpack-trees.c                |   6 +-
 24 files changed, 306 insertions(+), 79 deletions(-)
 create mode 100644 odb-helper.c
 create mode 100644 odb-helper.h
 create mode 100644 odb-remote.c
 create mode 100644 odb-remote.h