Re: [GSoC][PATCH v5 0/3] rebase -i: rewrite reflog operations in C

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 29, 2018, 16:55 UTC
Message-ID: <xmqqr2kpv8ft.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180629151435.31868-1-alban.gruin@gmail.com>

Alban Gruin <alban.gruin@gmail.com> writes:

Show 8 quoted lines

> This patch series rewrites the reflog operations from shell to C.  This
> is part of the effort to rewrite interactive rebase in C.
>
> The first commit is dedicated to creating a function to silence a
> command, as the sequencer will do in several places with these patches.
>
> This branch is based on ag/rebase-i-rewrite-todo, and does not conflict
> with pu (as of 2018-06-29).

Let's aggregate these topics into a single topic, and perhaps call it ag/rebase-i-in-c or something like that. Pretending as if they are separately replaceable does not make much sense, as you are not rerolling the earlier one and keep going forward with producing more parts that depends on the parts that have been submitted earlier.

These three patches looked more-or-less good; I may have spotted a few nits and suggested improvements, though.

Thanks.