Re: [GSoC][PATCH 3/3] rebase -i: rewrite checkout_onto() in C
- From
Alban Gruin <alban.gruin@gmail.com>
- Date
- Jun 18, 2018, 17:04 UTC
- Message-ID
- <3de6062e-d3cf-c85b-3663-31930b26e6e0@gmail.com>
- In-Reply-To
- <290d8b7c-3d82-e914-0399-e8dd5a6e1513@talktalk.net>
Hi Phillip,
Le 18/06/2018 à 18:09, Phillip Wood a écrit :
Show 6 quoted lines
>> + if (get_oid(orig_head, &oid))
>> + die(_("%s: not a valid OID"), orig_head);
>
> If this code is going to live long-term in sequencer.c then it would be
> better not to die, but return an error instead as it's part of libgit.
> Right, I will fix this.
Cheers, Alban