Re: [GSoC][PATCH 1/3] sequencer: add a new function to silence a command, except if it fails.

From

Christian Couder <christian.couder@gmail.com>

Date

Jun 18, 2018, 16:26 UTC

Message-ID

<CAP8UFD1PirEpeVwR=Zr4NAccrt_zGxjZkbDrjXNbQRp49zcjtg@mail.gmail.com>

In-Reply-To

<20180618131844.13408-2-alban.gruin@gmail.com>

Hi Alban,

On Mon, Jun 18, 2018 at 3:18 PM, Alban Gruin <alban.gruin@gmail.com> wrote:

> This adds a new function, run_command_silent_if_successful(),

He re the function is called run_command_silent_if_successful()...

> to
> redirect the stdout and stderr of a command to a strbuf, and then to run
> that command. This strbuf is printed only if the command fails. It is
> functionnaly similar to output() from git-rebase.sh.
>
> run_git_commit() is then refactored to use of
> run_command_silent_if_successful().

...here also...

[...]

> +static int run_command_silent_on_success(struct child_process *cmd)

...but here it is called run_command_silent_on_success().