Re: [PATCH v4 2/2] sequencer: fix quoting in write_author_script

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 8, 2018, 16:01 UTC
Message-ID: <xmqqr2j8j194.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAPig+cQdH+Xiunej1E6EnA6btFzZJTPo27cFY_UdaFZF7J7t-w@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 7 quoted lines

> What does concern me is that read_env_script() doesn't seem to care
> about such a malformed file; it doesn't do any validation at all.
> Contrast that with read_author_ident() which is pretty strict about
> the content it expects to find in the file. So, it might make sense to
> upgrade read_env_script() to do some sort of validation on each line
> (though that shouldn't be in this patch, and doesn't even need to be
> in this series).

I do not think it is within the scope of these bugfix patches, but I tend to agree that in the longer term it would be a good idea to unify these two helpers that read exactly the same file stored at rebase_path_author_script(), and make the result stricter, rather than tightening two helpers independently.