Re: [PATCH v4 1/2] sequencer: handle errors from read_author_ident()

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 8, 2018, 09:43 UTC
Message-ID: <CAPig+cStNhC=+naumnpw0+XzDKZ1Un+pziZ7sa8J0cu6O8pa4Q@mail.gmail.com>
In-Reply-To: <20180807093452.22524-2-phillip.wood@talktalk.net>

On Tue, Aug 7, 2018 at 5:35 AM Phillip Wood <phillip.wood@talktalk.net> wrote:

Show 11 quoted lines

> Check for a NULL return value from read_author_ident() that indicates
> an error. Previously the NULL author was passed to commit_tree() which
> would then fallback to using the default author when creating the new
> commit. This changed the date and potentially the author of the commit
> which corrupted the author data compared to its expected value.
>
> Helped-by: Eric Sunshine <sunshine@sunshineco.com>
> Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
> ---
>     changes since v3:
>      - Implemented the simpler scheme suggested by Eric

This iteration is much nicer, much simpler, and much easier to review. Thanks.